port(charted-space-core): 由图册核造流形(ChartedSpaceCore)#67
Open
LehengChen wants to merge 2 commits into
Open
Conversation
Contributor
|
感谢 #67(由图册核造流形)。现在 develop 上有两个已合并的注释范本可对照:
另:#65 已合并,base 可重定向到 develop(你这条目前还挂在上游 port 分支)。 |
Xinze-Li-Moqian
added a commit
that referenced
this pull request
Jun 14, 2026
Re-styled to OpenGA house style: architecture-layered module docstring, single-line Provenance footer, per-declaration single **Math.** docstrings (dropped **Eng.** segments). Theorem statements and proofs unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ac0d67b to
e3c1f75
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port(charted-space-core): manifold structure from a ChartedSpaceCore
What this ports
Lee, Introduction to Smooth Manifolds, §1, Lemma 1.35 (parts 1–4):
the separation, countability, smoothness and uniqueness properties of the
topology that a chart-family core (
ChartedSpaceCore) generates on itsunderlying set.
Chap01/Sec01_04/Lemma_1_35.leanOpenGALib/Manifold/Charts/ChartedSpaceCore.leanIndex wiring:
OpenGALib/Manifold.lean— addedimport OpenGALib.Manifold.Charts.ChartedSpaceCore(alphabetical, single-line change).
OpenGALib.lean(root index) — unchanged; already importsOpenGALib.Manifold.Core objects / results
The ticket lists no
core_objects(all four declarations are theorems):Manifold.toTopologicalSpace_t2Space— Lemma 1.35 (2): the generated topologyis Hausdorff when distinct points are separated by a common chart or by
disjoint chart domains.
Manifold.toTopologicalSpace_secondCountableTopology— Lemma 1.35 (3): thegenerated topology is second-countable when a countable subatlas covers the space.
Manifold.toChartedSpace_isManifold— Lemma 1.35 (4): smooth coordinate changesmake the generated charted space a smooth manifold.
Manifold.eq_toTopologicalSpace_of_chartedSpace— Lemma 1.35 (1): the generatedtopology is the unique one realizing the chart family as a charted space.
Design-neutral statement
TopologicalSpace,T2Space,SecondCountableTopology,ChartedSpace,IsManifold,ModelWithCorners,and Mathlib's
ChartedSpaceCorestructure. No OpenGASmoothManifoldpackaging class and no Lee
TopologicalManifoldwere introduced or relied on.transformsin the ticket; in particular norestatewas required (thesource already binds the four Mathlib classes individually, not via
TopologicalManifold).namespace changed (see Deviations).
Deviations from a literal copy
theorems under
namespace ChartedSpaceCore, which is not on the projectnamespace whitelist (
OpenGALib,Manifold,Riemannian,GeometricMeasureTheory,OpenPartialHomeomorph). Per the namespace policy,the declarations were moved into
namespace Manifoldwith their namesunchanged (
toTopologicalSpace_t2Space, etc.). This is a pure namespacemove, not a rename-to-dodge-the-gate; the Mathlib type
ChartedSpaceCoreitself is untouched and still referenced by its full name inside the proofs
(e.g.
ChartedSpaceCore.toTopologicalSpace).-- Declarations ... appended below,lean_leansearchnote) and the barenamespace ChartedSpaceCorewrapper. Added the module docstring (NAMING_CONVENTIONtemplate + provenance line) and
**Math.** / **Eng.**per-declarationdocstrings required by the docstring gate.
Provenance
import/smooth-manifolds-lee@a5f308c:staging/SmoothManifoldsLee/SmoothManifoldsLee/Chap01/Sec01_04/Lemma_1_35.leanGate results (local, full run — all six green)
Report:
projects/sml-to-openga/ledger/reports/ticket03-20260614T043136Z.jsonReview focus (minimal trusted base)
Proofs are kernel-checked. Reviewer need only confirm the statements name
the same mathematical objects as Lee's Lemma 1.35 (1)–(4) — i.e. that the four
theorem signatures (separation hypothesis ⇒ Hausdorff; countable cover ⇒
second-countable; smooth transitions ⇒
IsManifold; charted-space compatibility⇒ topology uniqueness) faithfully transcribe the source statements after the
ChartedSpaceCore → Manifoldnamespace move.Stacking note
Branch
port/charted-space-coreis cut from the stacked batch tipport/precompact-basis(not directly fromorigin/develop). Ticket #3 has nodeclared deps; the new module is an independent unit (it does not import the
coordinate-ball or precompact-basis modules).